Skip to content

features: client generator expects singular objects #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rphillips wants to merge 1 commit into from
Closed

features: client generator expects singular objects #234

rphillips wants to merge 1 commit into from

Conversation

@rphillips
Copy link
Contributor

@rphillips rphillips commented Mar 5, 2019 •
edited
Loading

I was getting this error on my informer. Note FeatureList does not exist, and FeaturesList does. We need to redo the pluralization and update the go-client.

I0305 14:38:13.242898   22751 reflector.go:169] Listing and watching *v1.Features from github.com/openshift/client-go/config/informers/externalversions/factory.go:101
E0305 14:38:13.244280   22751 reflector.go:134] github.com/openshift/client-go/config/informers/externalversions/factory.go:101: Failed to list *v1.Features: no kind "FeatureList" is registered for version "config.openshift.io/v1" in scheme "github.com/openshift/client-go/c
onfig/clientset/versioned/scheme/register.go:14"

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 5, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jwforres

If they are not already assigned, you can assign the PR to them by writing /assign @jwforres in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Contributor Author

rphillips commented Mar 5, 2019

/cc @derekwaynecarr @deads2k

@sjenning
Copy link
Contributor

sjenning commented Mar 5, 2019

@rphillips are we sure this is the issue?
@deads2k not sure if this is how we want to fix it if it is.

@rphillips
Copy link
Contributor Author

rphillips commented Mar 5, 2019

@sjenning I'm pretty certain the generator works this way. We can force the pluralization constructs with a comment, but we should probably conform to the defaults.

@rphillips rphillips force-pushed the fixes/fix_pluralization_feature branch 2 times, most recently from 516ea3b to dca255a Compare March 5, 2019 21:19
@deads2k
Copy link
Contributor

deads2k commented Mar 5, 2019

/hold

No, we need a generator fix. Maybe it didn't publish

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2019
@rphillips rphillips force-pushed the fixes/fix_pluralization_feature branch from dca255a to a77560f Compare March 5, 2019 21:24
@rphillips rphillips force-pushed the fixes/fix_pluralization_feature branch from a77560f to a4bd8fa Compare March 6, 2019 18:29
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2019

@rphillips: The following test failed for commit a4bd8fa, say /retest to rerun them:

Test name Details Rerun command
ci/prow/verify-client-go link /test verify-client-go

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sjenning
Copy link
Contributor

sjenning commented Mar 8, 2019

i think we should adhere to the upstream convention for resource naming rather than special-case the code generator. @deads2k what do you think?

@rphillips
Copy link
Contributor Author

rphillips commented Mar 8, 2019 •
edited
Loading

Closing in favor of openshift/kubernetes-code-generator#1 openshift/origin#22281

@rphillips rphillips closed this Mar 8, 2019
@rphillips rphillips mentioned this pull request Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rphillips @openshift-ci-robot @sjenning @deads2k